Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32367 )
Change subject: mb/google/sarien: Fix s5 touchscreen power leakage
......................................................................
Patch Set 11:
Patch Set 11:
Patch Set 11:
Patch Set 11:
Patch Set 11:
(1 comment)
There is each CL for both arcada and sarien in which both GPP_E7 and GPP_B21 are being controlled in S0iX.
For arcarda,
https://review.coreboot.org/c/coreboot/+/32311
For sarien,
https://review.coreboot.org/c/coreboot/+/32330
Aah interesting. So, the same power resource would ideally work with crrev.com/c/1577858 in kernel even for S5.
So I shall continue to make the change?
I meant try out the kernel change(crrev.com/c/1577858) without the change in .asl to see if the touchscreen power looks good in S5.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4229477b7149c0a75f4a8c6c7c453a37cc1c78c
Gerrit-Change-Number: 32367
Gerrit-PatchSet: 11
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Apr 2019 21:11:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment