Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40474 )
Change subject: device: Add a helper to find device behind a PCI-to-PCI bridge device
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40474/8/src/include/device/device.h
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/40474/8/src/include/device/device.h...
PS8, Line 298: DEVTREE_CONST
This would be normal 'const', I presume?
That is what I thought as well. But other functions here seemed to use DEVTREE_CONST for params. I believe those need to be fixed as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5672b35cda66431a0f1977f217bdf61d3012ace
Gerrit-Change-Number: 40474
Gerrit-PatchSet: 8
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Apr 2020 17:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment