Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31003/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31003/1//COMMIT_MSG@8
PS1, Line 8:
You could add some information here how you extracted
the VBT, e.g. from the BIOS rom? or from a running
system?
Also, what did you test? In theory, Linux should be
able to bring the display up even if the firmware
didn't.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibedb43852dc9b846850e1070b84f708c847b7dbf
Gerrit-Change-Number: 31003
Gerrit-PatchSet: 1
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 19 Jan 2019 09:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment