Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42282 )
Change subject: soc/intel/tgl: Disable hybrid storage mode in recovery mode
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@16
PS2, Line 16: Cq-Depend: chrome-internal:3100721
do I need to remove this? I wanted to mention this has a dependency on chrome-internal:3100721, and […]
Well, I don't think chrome-internal stuff is publicly visible, so I don't know what it is about (I have no access). I imagine it has to do with the CSME Lite firmware.
In any case, I would leave it as-is. It can be helpful for those with access to chrome-internal
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5397cfc007069debe3701bf1e38e81bd17a29f0c
Gerrit-Change-Number: 42282
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jun 2020 10:34:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment