Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39464 )
Change subject: mb/intel/tglrvp: Enable CNVi in devicetree for Tiger Lake UP3
......................................................................
Patch Set 2:
(3 comments)
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39464/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39464/1//COMMIT_MSG@7
PS1, Line 7: mb/tglrvp
mb/intel/tglrvp
Done
https://review.coreboot.org/c/coreboot/+/39464/1//COMMIT_MSG@9
PS1, Line 9: Enbale
Enable
Done
https://review.coreboot.org/c/coreboot/+/39464/1//COMMIT_MSG@9
PS1, Line 9: CNVi
this is specific to BT, right? […]
This patch turning on CNViBT and configuring GPIOs. 39315's main intention was to add dynamic SSDT for CNViWifi. But both are required for Integrated CNVi functionality to work
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39464
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71146960e0d53dae87946a0365dac6f224a72391
Gerrit-Change-Number: 39464
Gerrit-PatchSet: 2
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Mar 2020 05:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment