Attention is currently required from: Raul Rangel, Julius Werner.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58981 )
Change subject: console/printk: Add console_mutex
......................................................................
Patch Set 3:
(1 comment)
File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/58981/comment/bf3b38ce_dd82cd41
PS3, Line 86: thread_mutex_lock(&console_mutex);
Should this be wrapped in an if/else? i.e. do we need to spin_lock and thread_mutex_lock if spin_locks are enabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58981
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5858bb18723f32f6b1e6ef0ed31906d7c79d3fec
Gerrit-Change-Number: 58981
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 08 Nov 2021 15:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment