[coreboot-gerrit] Change in coreboot[master]: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively

[Peichao Li (Code Review)]

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )

Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> > DUT should be able to boot up from user side who gets this proto board with eMMC or SSD mounted.
> > > Considering to EVT, we still need to evaluate to boot up by 255.
> > >
> > > [Peichao:] Sure, this CL has included this logic, we can bring up normally from eMMC or SSD when SKU ID is 255
> >
> > If SKU ID is 255, the gpio.c doesn't set eMMC pins correct at least?
>
> Has the offline chat with paichao about:
> Although the eMMC GPIO NF setting is removed from early_gpio_table but it is originally in the gpio_table already so 255 can be with eMMC config from gpio_table.

Dear Marco, as we discussion, CBI pre-flash keep apply SKU ID 255 for Proto build, we will do CBI update and verification when Proto board back to Shenzhen office, we also update status to Google team. Thanks a lot!