Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36007 )
Change subject: soc/intel/braswell: Use common sb code for SPI lockdown configuration
......................................................................
Patch Set 4: -Code-Review
Patch Set 3:
Patch Set 3:
Patch Set 3:
(1 comment)
Using your patch fbg1701 reported 'Transaction error' when MRC cache data needs update.
I noticed that spi_flash_generic_probe() does not detect the winbond anymore. This is cause of the transaction error.
I updated the code so now it fetches SPIBAR correctly. Could you test?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e7be41a9470b37ad954d3120a67fc4d93633113
Gerrit-Change-Number: 36007
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Oct 2019 21:46:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment