Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39098 )
Change subject: soc/intel/tigerlake: Integrate Legacy 8254 timer support
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39098/2/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39098/2/src/soc/intel/tigerlake/fsp...
PS2, Line 139: Enable8254ClockGating
Looks like these are reserved in the stripped FSP headers, it will need to be added back for this to […]
we will update FSP header by EOD.
https://review.coreboot.org/c/coreboot/+/39098/2/src/soc/intel/tigerlake/fsp...
PS2, Line 140: 1
It looks like if Enable8254ClockGating==0 but .. […]
yes, make sense, will clean for other SOC as well at once
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeff5c4b92691ed6ba7b71541ed4f947d5d299a8
Gerrit-Change-Number: 39098
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 25 Feb 2020 02:48:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment