[coreboot-gerrit] Change in coreboot[master]: device: Add provision for multiple PCI segments

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40335 )

Change subject: device: Add provision for multiple PCI segments
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40335/6/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/40335/6/src/device/Kconfig@794 
PS6, Line 794: 	help
             : 	  This option allows you to select required PCI segment.
             : 
             : 	  Each PCI segment supports up to 256 buses (0-255).
             : 	  PCIE length selection is depends on PCI_SEGMENT_GROUPS.
             : 	  Formula for PCIE Length = PCI_SEGMENT_GROUPS * 256 MB
             : 	  If PCI segment is 1 then length of PCIEX region is 256MB to support 256 buses
             : 	  else PCIEX region would be multiple of 256MB based on PCI_SEGMENT_GROUPS.
I don't think a help text can help here. 256 buses is the maximum
per spec, but individual chips can have a lower limit, or even groups
of different size. So please move everything about the 256 to
`soc/intel/`.

The only thing we can say here for sure is that "this should be
changed when there are multiple PCI segment groups". But that's
just stating the obvious.