Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/m3800: add Acer Aspire M3800 desktop
......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Very nice. Some nits for the commit message. Great job!
https://review.coreboot.org/c/coreboot/+/44167/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44167/6//COMMIT_MSG@15
PS6, Line 15: is
I
https://review.coreboot.org/c/coreboot/+/44167/6//COMMIT_MSG@48
PS6, Line 48: SeaBIOS
Documenting the version would be great.
https://review.coreboot.org/c/coreboot/+/44167/6//COMMIT_MSG@57
PS6, Line 57: SuperIO
Super IO (or I/O)
https://review.coreboot.org/c/coreboot/+/44167/6//COMMIT_MSG@64
PS6, Line 64: SuperIO
Super I/O
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I846cf5f4f1ef27fc644676a4c6f7a333e061f6cf
Gerrit-Change-Number: 44167
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Comment-Date: Tue, 01 Sep 2020 13:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment