Attention is currently required from: Stefan Reinauer, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49232 )
Change subject: Fix tsc_freq_mhz() on some platforms ......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/timer/timer.c:
https://review.coreboot.org/c/coreboot/+/49232/comment/21383516_624d0212 PS1, Line 57: if (cpuid_get_max_func() < 0x15) : return 0; Drop this since the caller now performs this check?
https://review.coreboot.org/c/coreboot/+/49232/comment/798bf29d_8b33b6f4 PS1, Line 113: platform_info = rdmsr(MSR_PLATFORM_INFO); : return CONFIG_CPU_BCLK_MHZ * ((platform_info.lo >> 8) & 0xff); Is this true for all x86 models? Or does there need to be a model check? Some older models I think reported using MSR_IA32_PERF_STATUS? Not sure if we care about those here?