chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45153 )
Change subject: mb/google/zork:Add dptc interface support for morphius ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... PS8, Line 43:
Blank line change not needed.
Done
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/include/variant/thermal.h:
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... PS8, Line 4: #define DPTC_SUPPORT_ENABLE
I think this should go in ec.h since it is used only by the EC.
Done
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... PS8, Line 23: # End : OPN Performance Configuration
This should be after the new lines being added?
Done
https://review.coreboot.org/c/coreboot/+/45153/8/src/mainboard/google/zork/v... PS8, Line 26: register "slow_ppt_limit_tablet_mode" = "20000" #mw : register "fast_ppt_limit_tablet_mode" = "24000" #mw
These values are exactly the same as the default values above. […]
From issue describe, morphius will use this configure for tablet mode.