Felix Held has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82249?usp=email )
Change subject: cpu/x86/pae/pgtbl.c: extract reusable code from memset_pae()
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/pae/pgtbl.c:
https://review.coreboot.org/c/coreboot/+/82249/comment/7b074c09_00357358?usp... :
PS3, Line 113: * @return 0 on success, 1 on error
not directly related to this patch, but something for a follow-up: it would make the code much easier to read if enum cb_err was used here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82249?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8aa80eb246ff0e77e1f51d71933d3d00ab75aaeb
Gerrit-Change-Number: 82249
Gerrit-PatchSet: 4
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 May 2024 13:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No