Attention is currently required from: Reka Norman, Paul Menzel, Arthur Heymans, Michael Niewöhner, Aaron Durbin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36674 )
Change subject: arch/x86: Optionally cache cbmem in romstage
......................................................................
Patch Set 22: Code-Review+1
(1 comment)
File src/cpu/x86/cache/cache.c:
https://review.coreboot.org/c/coreboot/+/36674/comment/200e3fb5_9f016d47
PS22, Line 82: [
`]`? […]
Ah, we're used to `[a, b)` instead of `[a, b[`. https://en.wikipedia.org/wiki/Interval_(mathematics)#Including_or_excluding_...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89fdc6066027447bf72968c66e6f5eb5fbb630c7
Gerrit-Change-Number: 36674
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 21 Oct 2022 09:33:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment