Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46301 )
Change subject: soc/intel/common: drop default to enable the PIT if SeaBIOS is chosen
......................................................................
Patch Set 1:
Well. Sure that actually works?
The pmtimer is used in case seabios runs on qemu and initializes the (virtual) acpi pci device.
I doubt this also happens when running as coreboot payload.
I have reason to assume it does:
platform_hardware_setup() calls coreboot_platform_setup() calls
find_acpi_features() calls pmtimer_setup(). Didn't test it though,
but I assume the PM timer would be used.
And the PM timer always works as it's emulated in the worst case :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd75800678707a92110682347c7cfb93e25109a4
Gerrit-Change-Number: 46301
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gerd Hoffmann
kraxel@redhat.com
Gerrit-Reviewer: Kevin O'Connor
kevin@koconnor.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 14 Oct 2020 20:33:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment