Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49134 )
Change subject: mb/google/dedede: Disable Fast slew rate for deeper c states ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49134/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49134/2//COMMIT_MSG@9 PS2, Line 9: We need to disable fast slew rate for deeper package C states : while enabling acoustic noise mitigations.
Is this always the case? If so, I'd suggest handling this in SoC code instead.
The UPD documentation says depending on whether Acoustic Noise Mitigation is enabled, this can be disabled. If so, as Angel Pons mentioned, it can be set in the SoC code itself based on the status of Acoustic Noise Mitigation feature.