Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Program CxODT value for each channel ......................................................................
Patch Set 30:
(5 comments)
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@9 PS28, Line 9: raison
reason :-)
Done
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@9 PS28, Line 9: programm
program
Done
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@10 PS28, Line 10: for
drop "for"
Done
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@10 PS28, Line 10: eually
equally
Done
https://review.coreboot.org/c/coreboot/+/18548/21/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/21/src/northbridge/intel/i945... PS21, Line 2460: if (!(sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED && : sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) {
The logic is not the same as the new code. […]
Ack