Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36542 )
Change subject: soc/intel/icelake: Make TSEG_BASE align to TSEG_SIZE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36542/1/src/soc/intel/icelake/smmre... File src/soc/intel/icelake/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/36542/1/src/soc/intel/icelake/smmre... PS1, Line 181: tseg_base = ALIGN(tseg_base, tseg_size); I'm not sure if this is the best idea. I think you want to not program SMRR and warn about it. See cpu/intel/smm/gen1/smmrelocate.c.
Btw the cpu/intel file is used over many different targets and looks very similar to this code. It might be worth looking into making this or the gen1/ssmrelocate.c file common?