23 Jan
2020
23 Jan
'20
4:48 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38536 )
Change subject: libpayload/corebootfb: Fix character buffer relocation ......................................................................
Patch Set 1:
Please mention that it fixes non-bootable payloads?
It doesn't. It may fix something, however. There's a potential corruption of unreserved memory. Which may lead to more subtle errors or no errors at all.
In case of FILO, it kept writing to the old heap address after relocation. If the kernel to be loaded resides at that address, *boom*, but otherwise /whatever/.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38536
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic03150f0bcd14a6ec6bf514dffe2b9153d5a6d2a
Gerrit-Change-Number: 38536
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jan 2020 15:48:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment