[coreboot-gerrit] Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18975 )

Change subject: abuild: Treat command line for recursive invocations as bash array
......................................................................

Patch Set 3:

(3 comments)

currently the -t "vendor1/board1 vendor2/board2", doesn't work although I think that would be a good addition.

https://review.coreboot.org/#/c/18975/3/util/abuild/abuild
File util/abuild/abuild:

PS3, Line 19: ABUILD_DATE="Dec 6, 2016"
            : ABUILD_VERSION="0.10.01"
Do you think this change is worth updating the version and date?

PS3, Line 784: local num_targets=$(wc -w <<<$targets)
> From shellcheck

local num_targets=$(wc -w <<<$targets)
              ^-- SC2155: Declare and assign separately to avoid masking return values.
                                     ^-- SC2086: Double quote to prevent globbing and word splitting.

PS3, Line 785: local cpus_per_target=$(((${cpus:-1} + $num_targets - 1) / $num_targets))
> From shellcheck:

local cpus_per_target=$(((${cpus:-1} + $num_targets - 1) / $num_targets))
                                               ^-- SC2004: $/${} is unnecessary on arithmetic variables.
                                                                   ^-- SC2004: $/${} is unnecessary on arithmetic variables.