[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Add logo support

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37515 )

Change subject: drivers/intel/fsp2_0: Add logo support
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 1:
>
> Since this seems to be one of those "move responsibility into FSP" things: what does this provide over our coreboot-side splash screen feature?

Basically it adds BMP support, which is not in the current coreboot implementation. This allows  us to use one logo as splash screen for coreboot and a logo published in the BGRT table. The EDK payloads also use the BMP format.

So this is not a replacement, it is just an additional feature that can be used when needed.

https://review.coreboot.org/c/coreboot/+/37515/1/src/drivers/intel/fsp2_0/Kc... 
File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/37515/1/src/drivers/intel/fsp2_0/Kc... 
PS1, Line 164: 	  BMP file only. The uncompressed size can be up to 1 MB.
> mention that it can be compressed as well

Done