Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47095 )
Change subject: sb/intel/lynxpoint: Use common AHCI library
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47095/4/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47095/4/src/southbridge/intel/lynxp...
PS4, Line 97: const uintptr_t ahci_bar = pci_read_config32(dev, PCI_BASE_ADDRESS_5);
this should use probe_resource instead
Yeah, I'm going to make a follow-up and update all platforms at once
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62a26d74fe78dc0158b383da9126c56746722c53
Gerrit-Change-Number: 47095
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 11:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment