Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant
......................................................................
Patch Set 28:
Patch Set 28: Code-Review+1
Patch Set 28:
Is there any flaw that prevents this commit from being Code-Review +2 now?
There are some unresolved comments which should be addressed or marked as resolved.
To expand on this, until all comments are marked resolved, the patch can't be merged even if it has +2. If you look in the code review section, you'll see the "All-Comments resolved" section marked "No votes."
To see what still needs to be addressed, click on one of the patchset selectors at the top of the files section and look for anything that says 'X comments, Y unresolved'.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb
Gerrit-Change-Number: 41390
Gerrit-PatchSet: 28
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 15:14:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment