[coreboot-gerrit] Change in coreboot[master]: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44293 )

Change subject: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic
......................................................................

Patch Set 4:

(2 comments)

Patchset:

PS4:
> It looks like this code would be obsolete with  https://review.coreboot. […]

Perhaps, but 3mdeb might not have intention to fix fam15tn or fam16kb.

File src/drivers/amd/agesa/s3_mtrr.c:

https://review.coreboot.org/c/coreboot/+/44293/comment/125f1856_692006a5 
PS4, Line 47: 		mtrr_save->mtrr_phys_mask[i] = rdmsr(MTRR_PHYS_BASE(i));
> > MTRR_PHYS_MASK(i) […]

Hmm.. yes, MTRR solution with default type as WB might resume incorrectly?