Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68635 )
(
7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/alderlake: Hook up DisableDynamicTccoldHandshake to dev tree ......................................................................
soc/intel/alderlake: Hook up DisableDynamicTccoldHandshake to dev tree
This commit provides a dev tree setting for partners to enable/disable TccoldHandshake for the sighting in doc:723158
BUG=b:221461379 BRANCH=firmware-brya-14505.B TEST=compile ok and FSP UPD is config properly
Change-Id: Ica13b98204acebef7f0b9a4411b4ac19f53cad6e Signed-off-by: Kane Chen kane.chen@intel.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/68635 Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/romstage/fsp_params.c 2 files changed, 34 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Eric Lai: Looks good to me, approved Jérémy Compostella: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h index 8e76e55..33549bc 100644 --- a/src/soc/intel/alderlake/chip.h +++ b/src/soc/intel/alderlake/chip.h @@ -680,6 +680,13 @@ * IGD panel configuration */ struct i915_gpu_panel_config panel_cfg; + + /* + * Enable or Disable Tccold Handshake + * Default is set to 0. + * Set this to 1 in order to disable Tccold Handshake + */ + bool disable_dynamic_tccold_handshake; };
typedef struct soc_intel_alderlake_config config_t; diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c index 2e8a73c..df94e48 100644 --- a/src/soc/intel/alderlake/romstage/fsp_params.c +++ b/src/soc/intel/alderlake/romstage/fsp_params.c @@ -270,6 +270,11 @@ /* TCSS DMA */ m_cfg->TcssDma0En = is_devfn_enabled(SA_DEVFN_TCSS_DMA0); m_cfg->TcssDma1En = is_devfn_enabled(SA_DEVFN_TCSS_DMA1); + +#if CONFIG(SOC_INTEL_RAPTORLAKE) + m_cfg->DisableDynamicTccoldHandshake = + config->disable_dynamic_tccold_handshake; +#endif }
static void fill_fspm_usb4_params(FSP_M_CONFIG *m_cfg,