[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Fix PMC and GPIO block values for PCH-H

[Jeremy Soller (Code Review)]

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33941 )

Change subject: soc/intel/cannonlake: Fix PMC and GPIO block values for PCH-H
......................................................................

Patch Set 5:

(1 comment)

I have ordered the defines by value, and made them all hexadecimal

https://review.coreboot.org/#/c/33941/2/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/gpio_soc_defs_cnp_h.h:

https://review.coreboot.org/#/c/33941/2/src/soc/intel/cannonlake/include/soc... 
PS2, Line 36: #define GPD			5
> Please either use hex or decimal for all numbers. […]

Done