Attention is currently required from: Raul Rangel, Patrick Rudolph, Mariusz Szafrański, Jonathan Zhang, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Michal Motyl, Tim Chu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )
Change subject: src/*: Make PCI ID macro names shorter ......................................................................
Patch Set 7:
(10 comments)
File src/include/device/pci_ids.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/9198a5e0_e4e3b639 PS7, Line 150: #define PCI_DID_COMPAQ_TRIFLEX_IDE 0xae33 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/114a2ff8_dc7e90b5 PS7, Line 1863: #define PCI_DID_CBOARDS_DAS1602_16 0x0001 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/b25afc8e_10d989ec PS7, Line 1945: #define PCI_DID_APPLICOM_PCIGENERIC 0x0001 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/795304d8_aeb68465 PS7, Line 1947: #define PCI_DID_APPLICOM_PCI2000PFB 0x0003 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/6414571b_37923190 PS7, Line 2097: #define PCI_VID_AKS 0x416c 'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/2fd0e307_c3a8c181 PS7, Line 2098: #define PCI_DID_AKS_ALADDINCARD 0x0100 'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/124e1e5f_4b4b0c2d PS7, Line 2099: #define PCI_DID_AKS_CPC 0x0200 'AKS' may be misspelled - perhaps 'ASK'?
File src/soc/intel/skylake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/5e9b6744_77e514fd PS7, Line 215: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) { code indent should use tabs where possible
File src/southbridge/amd/agesa/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/a80f5f18_557fb51a PS7, Line 66: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) { else should follow close brace '}'
File src/southbridge/amd/pi/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133896): https://review.coreboot.org/c/coreboot/+/39331/comment/cd2bf9c0_6cf0e824 PS7, Line 41: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) { else should follow close brace '}'