Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39137 )
Change subject: vboot: Upgrade kernel space to v1.0 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39137/2/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/39137/2/src/security/vboot/secdata_... PS2, Line 94: VB2_SECDATA_MAX_SIZE I think this is more of an implementation detail, and vboot should not have to worry about it. How about:
max(VB2_SECDATA_KERNEL_SIZE, VB2_SECDATA_FIRMWARE_SIZE)
(I think we can use KERNEL_SIZE here -- the only reason I could think of using KERNEL_MAX_SIZE is if our vb2_secdata_kernel structure *shrinks* in a minor uprev. Julius, do you think we need to be worried about that case?)
https://review.coreboot.org/c/coreboot/+/39137/2/src/security/vboot/secdata_... PS2, Line 336: VB2_SECDATA_KERNEL_SIZE This should use VB2_SECDATA_KERNEL_SIZE_V10, no?
https://review.coreboot.org/c/coreboot/+/39137/2/src/security/vboot/secdata_... PS2, Line 383: values value