Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31727 )
Change subject: util/amdfwtool: Clarify calculations with structures ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@a786 PS2, Line 786: Was this just a reserved byte?
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@a796 PS2, Line 796: Keep this comment or make an enum?
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@809 PS2, Line 809: sizeof(embedded_firmware); Since this is 24 bytes (0x18), i'm not sure this is right if we were expecting the following table to be 16-byte aligned. Do we need an alignment macro?
https://review.coreboot.org/#/c/31727/2/util/amdfwtool/amdfwtool.c@851 PS2, Line 851: 1 Variable or #define for this?