Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45943 )
Change subject: vc/amd/fsp: Update bl_errorcodes_public.h
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45943/2/src/vendorcode/amd/fsp/pica...
File src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_errorcodes_public.h:
https://review.coreboot.org/c/coreboot/+/45943/2/src/vendorcode/amd/fsp/pica...
PS2, Line 3: * Copyright (c) 2020, Advanced Micro Devices, Inc.
does this need a dual date Copyright? (e.g. 2019-2020) I see both styles in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82585c74d74139a96419b9bffe1df3b8c344eb5f
Gerrit-Change-Number: 45943
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 21:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment