Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )
Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG@8 PS1, Line 8: I think it will be good to add some information here explaining that the reason why DRIVER_I2C_TPM_ACPI was made dependent on I2C_TPM was to hide it from menuconfig if I2C_TPM was not selected. The same can be achieved by adding a conditional on the prompt for the config. So, there should not be any functional or build time change because of this CL.
https://review.coreboot.org/c/coreboot/+/48222/1/src/drivers/i2c/tpm/Kconfig File src/drivers/i2c/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/48222/1/src/drivers/i2c/tpm/Kconfig... PS1, Line 44: " if I2C_TPM
to ensure that the Kconfig is not visible in menuconfig unless I2C_TPM is selected.