Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31707 )
Change subject: cbfstool: Support new FMD flag "PRESERVE" ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
I don't know anything about the Lex and Yacc stuff but I assume you know what you're doing. ^^
(BTW, I think it may be more readable to separate attributes by commas instead of spaces, but maybe that's just me. And if spaces are easier to do with the parser, that's fine too.)
https://review.coreboot.org/#/c/31707/3/util/cbfstool/fmd_parser.y File util/cbfstool/fmd_parser.y:
https://review.coreboot.org/#/c/31707/3/util/cbfstool/fmd_parser.y@111 PS3, Line 111: region_flag: FLAG_PRESERVE { $$.v = 0; $$.f.preserve = 1; }; Does this work if both flags are set?