[coreboot-gerrit] Change in coreboot[master]: [RFC]drivers/smmstore: Implement SMMSTORE version 2

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )

Change subject: [RFC]drivers/smmstore: Implement SMMSTORE version 2
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/store.... 
File src/drivers/smmstore/store.c:

https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/store.... 
PS7, Line 307: BIOS_WARNING
warning or error? I assume the latter since we're returning -1

https://review.coreboot.org/c/coreboot/+/40520/7/src/drivers/smmstore/store.... 
PS7, Line 315: printk(BIOS_ERR, "smm store: lookup of com buffer failed\n");
we should return -1 after this, otherwise function returns 0 and com_buffer is 0 since not initialized