Attention is currently required from: Kangheui Won, Reka Norman, Tim Wawrzynczak, Nick Vaccaro, Tyler Wang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64439 )
Change subject: spd: Add new LP5 part Samsung K3LKLKL0EM-MGCN
......................................................................
Patch Set 4:
(1 comment)
File spd/lp5/memory_parts.json:
https://review.coreboot.org/c/coreboot/+/64439/comment/f72bf391_1e36ee65
PS4, Line 68: 8
I think section 4 of the datasheet onwards is just copied from the LP5 spec, and not all of it neces […]
oh that make sense. DQ 16 should be width 16.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5648f297130eaf8541d99b2db7777774a0b1d8fc
Gerrit-Change-Number: 64439
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cathy Chen
cathy_chen@quanta.corp-partner.google.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 May 2022 01:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment