HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Don't use both of _ADR and _HID
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/12/src/mainboard/aopen/dxplpl...
File src/mainboard/aopen/dxplplusu/acpi/p64h2.asl:
https://review.coreboot.org/c/coreboot/+/36317/12/src/mainboard/aopen/dxplpl...
PS12, Line 21: /* Name (_HID, "ACPI000A") */
Why not removing the _HID lines?
not sure if the _ADR is correct , so maybe it needs test on real hardware.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Dec 2019 19:24:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment