[coreboot-gerrit] Change in coreboot[master]: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44293 )

Change subject: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic
......................................................................

Patch Set 4:

(1 comment)

File src/drivers/amd/agesa/s3_mtrr.c:

https://review.coreboot.org/c/coreboot/+/44293/comment/fecf643e_3183d67f 
PS4, Line 10: 
            : struct mtrr_backup {
            : 	msr_t mtrr_fix_64k_00000;
            : 	msr_t mtrr_fix_16k_80000;
            : 	msr_t mtrr_fix_16k_a0000;
            : 	msr_t mtrr_fix_4k_xx000[8]; /* 4K_C0000 -- 4K_F8000 */
            : 	msr_t mtrr_phys_base[8];
            : 	msr_t mtrr_phys_mask[8];
            : 	msr_t syscfg;
            : 	msr_t top_mem;
            : 	msr_t top_mem2;
            : };
> The code probably looks a lot simpler using a MSR address array.

Maybe it is wiser to put effort in PARALLEL_MP for fam15tn/16kb if you already made it compatible with ASEG_SMM. Looks like save_bsp_msrs() and load_msr in sipi_vector.S achieves the same thing.