Attention is currently required from: Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 25:
(6 comments)
Patchset:
PS25: This looks very similar to the MBP10,1 port. Using variants would reduce the amount of redundant stuff.
File Documentation/mainboard/apple/macbookair5_2.md:
https://review.coreboot.org/c/coreboot/+/32604/comment/126a9904_3c06c1a8 PS25, Line 18: 8MB MiB
File Documentation/mainboard/index.md:
https://review.coreboot.org/c/coreboot/+/32604/comment/0505f41f_2233b410 PS25, Line 13: whitespace
File src/mainboard/apple/macbookair5_2/cmos.layout:
PS25: Same as on MBP 10,1 patch
File src/mainboard/apple/macbookair5_2/early_init.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/88801300_91a74497 PS25, Line 33: } The code for MBP10,1 dies if no SPD is found, I wonder why this is different here?
File src/mainboard/apple/macbookair5_2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/a6818abb_686d1b1f PS25, Line 9: GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); nit: two more tabs