Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34006 )
Change subject: mb/google/hatch: Fix PRE-CBMEM console overflow issue ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34006/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34006/1//COMMIT_MSG@11 PS1, Line 11: issue.
:) agree, i had one internal bug hence i have mentioned fixing issue. […]
@Nico, This fixes our issue, so we would like to submit this CL but as you said to increase default value itself. I have few opens
1. below are the mb which override default value
src/mainboard/asrock/h110m/Kconfig:40:config PRERAM_CBMEM_CONSOLE_SIZE = 0xd00 src/mainboard/google/reef/Kconfig:108:config PRERAM_CBMEM_CONSOLE_SIZE = 0xe00 src/mainboard/intel/kblrvp/Kconfig:81:config PRERAM_CBMEM_CONSOLE_SIZE = 0xd00 src/soc/amd/stoneyridge/Kconfig:106:config PRERAM_CBMEM_CONSOLE_SIZE =0x1600 src/soc/amd/picasso/Kconfig:99:config PRERAM_CBMEM_CONSOLE_SIZE = 0x1600
2. I don;t think its good idea to make default as 0x1600 which is selected max today from mb and remove this override from mb side
3. I would recommend to increase default from 0xc00 -> 0xe00 and remove mb overrides which falls in that category. I'm not very sure why on AMD platform its set to very high value.
need ur feedback. Other our CL holds good for review