Attention is currently required from: Tim Wawrzynczak, Stefan Reinauer, Angel Pons. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 )
Change subject: util/ifdtool: Use Pch Strap Length(PSL) to uniquely identify IFDv2 chipsets ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: Thanks for looking into this.
File util/ifdtool/ifdtool.h:
https://review.coreboot.org/c/coreboot/+/54305/comment/f407454b_0c9d37d7 PS2, Line 38: CHIPSET_N_J_SERIES_APOLLO_GEMINI_LAKE, /* Apollo Lake, Gemini Lake: APL and GLK have different IFDs (e.g. FLCOMP bitfields are different). I'd handle them separately. See CB:54276 for a flashrom patch, which I tested and correctly identifies a GLK IFD.
https://review.coreboot.org/c/coreboot/+/54305/comment/7aa5333b_1d0fddfc PS2, Line 60: macros not macros
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/54305/comment/d716cd4e_5e4d8cd5 PS2, Line 273: read_freq = (fcba->flcomp >> 17) & 7; This bitfield was repurposed in CNP/GLK and newer. It used to be "Read Clock Frequency", but it's "ec_max_freq" on newer platforms.