Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41368 )
Change subject: nb/intel/i440bx: add resources during read_resources() ......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/41368/2/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41368/2/src/northbridge/intel/i440b... PS2, Line 37: pci_tolm = find_pci_tolm(dev->link_list); This is incorrect. It's implicitly deriving the existence of ram using find_pci_tolm() walking the resource list that isn't fully seeded at read_resource() time. The check below of tolmk doesn't make sense. I'm not sure why find_pci_tolm() exists. i945 seems wrong in this regard as well, but i945 is just reporting the value. Here the code is trying to use the value to implicit measure ram capacity.