Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47545 )
Change subject: mb/amd/mandolin: Add decode range for LPC debug card ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47545/2/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/47545/2/src/mainboard/amd/mandolin/... PS2, Line 31: base
Maybe config address?
Done
https://review.coreboot.org/c/coreboot/+/47545/2/src/mainboard/amd/mandolin/... PS2, Line 45: default 0x2E if SMSC_SIO1036_BASE_2E
Ah, this line needs to come out now
Done
https://review.coreboot.org/c/coreboot/+/47545/2/src/mainboard/amd/mandolin/... PS2, Line 46: 0x4E
nit: lower case here and on the next line
Done
https://review.coreboot.org/c/coreboot/+/47545/2/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47545/2/src/mainboard/amd/mandolin/... PS2, Line 15: || (CONFIG_SUPERIO_ADDR_RANGE == 0x2e)
You can remove this now
Done