Yanjie Jiang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35162 )
Change subject: mediatek/mt8183: put md_init flow to romstage ......................................................................
mediatek/mt8183: put md_init flow to romstage
Consider the association between modem[1] and DCXO, modem should be powerred off before DCXO, so we move it to romstage from ramstage.
BRANCH=none Test=Boots correctly on Kukui, suspend test pass.
Change-Id: Id147e30f2e2bbf018443bbadc869cc8e004cc65b Signed-off-by: Yanjie.jiang <yanjie.jiang@mediatek.com --- M src/mainboard/google/kukui/romstage.c M src/soc/mediatek/mt8183/Makefile.inc M src/soc/mediatek/mt8183/soc.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/35162/1
diff --git a/src/mainboard/google/kukui/romstage.c b/src/mainboard/google/kukui/romstage.c index baaca43..71e0ba8 100644 --- a/src/mainboard/google/kukui/romstage.c +++ b/src/mainboard/google/kukui/romstage.c @@ -15,6 +15,7 @@
#include <arch/stages.h> #include <soc/emi.h> +#include <soc/md_ctrl.h> #include <soc/mmu_operations.h> #include <soc/mt6358.h> #include <soc/pll.h> @@ -30,6 +31,7 @@
mt6358_init(); mt_pll_raise_ca53_freq(1989 * MHz); + mtk_md_early_init(); rtc_boot(); mt_mem_init(get_sdram_config()); mtk_mmu_after_dram(); diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc index 6e2207a..4655d7f 100644 --- a/src/soc/mediatek/mt8183/Makefile.inc +++ b/src/soc/mediatek/mt8183/Makefile.inc @@ -39,6 +39,7 @@ romstage-y += ../common/timer.c romstage-y += ../common/uart.c romstage-y += ../common/wdt.c +romstage-y += md_ctrl.c
ramstage-y += auxadc.c ramstage-y += ../common/cbmem.c emi.c @@ -51,7 +52,6 @@ ramstage-y += ../common/uart.c ramstage-y += ../common/usb.c ramstage-y += ../common/wdt.c -ramstage-y += md_ctrl.c
CPPFLAGS_common += -Isrc/soc/mediatek/mt8183/include CPPFLAGS_common += -Isrc/soc/mediatek/common/include diff --git a/src/soc/mediatek/mt8183/soc.c b/src/soc/mediatek/mt8183/soc.c index 501ae19..7dcbce9 100644 --- a/src/soc/mediatek/mt8183/soc.c +++ b/src/soc/mediatek/mt8183/soc.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <soc/emi.h> -#include <soc/md_ctrl.h> #include <soc/mmu_operations.h> #include <symbols.h>
@@ -27,7 +26,6 @@ static void soc_init(struct device *dev) { mtk_mmu_disable_l2c_sram(); - mtk_md_early_init(); }
static struct device_operations soc_ops = {