Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39839 )
Change subject: lp/drivers/usb: Add quirk for QEMU XHCI root hub
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers...
File payloads/libpayload/drivers/usb/generic_hub.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers...
PS2, Line 222: hub_status_changed
but the current name is accurate.
It is from xHCI perspective. But this is not the xhci driver. To me it
looks like driving a nail through all the layers. The quirk infrastructure
encourages this, maybe I'll try to get rid of it in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6689cb1dbb24c93d45f5c5ef040b713925d07588
Gerrit-Change-Number: 39839
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Apr 2020 22:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment
