Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38222 )
Change subject: soc/amd/stoneyridge: Change some local SMBus function signatures
......................................................................
Patch Set 4:
Patch Set 4: Code-Review-2
This is on indefinite hold since forking the copy on picasso/ is currently rejected. I am not going to make the files out-of-sync.
Cursed idea: Make picasso/ use its own header, and switch to common code once things can be tested. I would not block cleanups of the entire codebase just for a single platform, especially if that platform is still WIP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic912b91daf79ecd2c276a383edcda563891cf643
Gerrit-Change-Number: 38222
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jan 2020 09:14:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment