Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48069 )
Change subject: mb/google/brya: Enable ACPI and add ACPI table
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m...
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m...
PS3, Line 16: static unsigned long mainboard_write_acpi_tables(
: const struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
: {
: return current;
: }
Do you have a plan for using this later?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08513ec159b69535f742a1fd70cdec9ec845d414
Gerrit-Change-Number: 48069
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Nov 2020 21:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment