build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34928 )
Change subject: intel/fsp1_0,baytrail,rangeley: Tidy up use of preprocessor ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34928/7/src/southbridge/intel/fsp_r... File src/southbridge/intel/fsp_rangeley/soc.h:
https://review.coreboot.org/c/coreboot/+/34928/7/src/southbridge/intel/fsp_r... PS7, Line 55: void acpi_fill_in_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/34928/7/src/southbridge/intel/fsp_r... PS7, Line 55: void acpi_fill_in_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/34928/7/src/southbridge/intel/fsp_r... PS7, Line 69: int smbus_read_byte(unsigned device, unsigned address); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/34928/7/src/southbridge/intel/fsp_r... PS7, Line 69: int smbus_read_byte(unsigned device, unsigned address); Prefer 'unsigned int' to bare use of 'unsigned'