Attention is currently required from: Hung-Te Lin, yu jiaxin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 )
Change subject: mb/google/corsola: Support audio ......................................................................
Patch Set 3:
(12 comments)
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60738/comment/74459542_40613819 PS1, Line 29: /* Power on audio */
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/3e3e6413_f544da3f PS1, Line 30: mtcmos_audio_power_on();
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/9fb43bcd_82945bfd PS1, Line 30: mtcmos_audio_power_on();
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/4ff9f060_42402130 PS1, Line 32: /* Set up I2S */
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/a1aef76b_a9d4a613 PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/262af78d_2cda8824 PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/754e7bfc_2fcbf8a4 PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/19502650_42486298 PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/6a317075_1d60502e PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/4bc22417_92be2011 PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/4b30e964_e95d9772 PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60738/comment/47a4e7e3_7d33322f PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO);
please, no spaces at the start of a line
Please fix.