Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37816 )
Change subject: AGESA fam14: Remove early PCI subsystem ID setting
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37816/1/src/cpu/amd/agesa/family14/...
File src/cpu/amd/agesa/family14/fixme.c:
https://review.coreboot.org/c/coreboot/+/37816/1/src/cpu/amd/agesa/family14/...
PS1, Line 78: /* Set Ontario Link Data */
: PciAddress.AddressValue = MAKE_SBDFO(0, 0, 0, 0, 0xE0);
: PciData = 0x01308002;
: LibAmdPciWrite(AccessWidth32, PciAddress, &PciData, &StdHeader);
Remove these too. The subsystem ID is set via indexed registers.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4e95c68517b01647049b5cbd50bf5a3974a9c3a
Gerrit-Change-Number: 37816
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Dec 2019 15:46:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment