Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40513 )
Change subject: ec/google/chromeec: Fix acpi_name() for Chrome EC device
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40513/3/src/ec/google/chromeec/ec_a...
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/40513/3/src/ec/google/chromeec/ec_a...
PS3, Line 25: return "EC0.CREC";
Leave a comment here about if we have a driver dealing with AML generation that EC0 needs to be omit […]
Okay, I will add that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec4b0226d1e98ddeb0f8ed8b89477fc4f453d221
Gerrit-Change-Number: 40513
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Apr 2020 18:34:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment